Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example project w8 #329

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

malvinamaria
Copy link

No description provided.

@malvinamaria
Copy link
Author

p

@@ -10,4 +10,4 @@ Describe how you approached to problem, and what tools and techniques you used t

## View it live

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some thoughts here about how you did this project.

Copy link

@PerErikAndreas PerErikAndreas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Malwina!

Great work with this project!

Review:
The page showed up properly and did not crash or act strange in any situation that I could see. The requirements was to make a moviepage from an API and display movie thumbnails that were clickable and led you to a details page using react router, and you made that.

The code is well-structured especially the css that has comments for each part. Nice and clear! I left some single comments in the code.
Nice work!

}

.movie-container {
display: flex;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a gap between the columns in the flexbox. I think you could make the pictures responsive to fill that gap.
We used grid here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants