Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newssite: weaving #525

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

newssite: weaving #525

wants to merge 5 commits into from

Conversation

gittebe
Copy link

@gittebe gittebe commented Aug 25, 2024

@JennieDalgren JennieDalgren self-assigned this Aug 27, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with you project. There isn't anything you need to change, the project meets the requirements.

CSS Grid Layout:

Excellent use of CSS Grid to structure the news articles section!
Tip: You could simplify your grid layout by using grid-template-columns: repeat(auto-fit, minmax()) for improved responsiveness without hardcoding breakpoints. I know we have shown how to do this with break points. This is just something to explore, for future use.

Media Queries:

The site adapts well across devices, especially maintaining the correct column layouts on desktop (4 columns), tablet (2 columns), and mobile (1 column).

Semantic HTML and Structure:

Nice work using semantic tags like

and . This makes your HTML easier to understand and improves accessibility.

Code Organization:

Your CSS is well-organized, but adding a few more comments could help clarify more complex sections, such as your media queries. This will make future updates easier.

Fantastic job overall, keep up the great work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants