Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News site project - Jenny Andersén #533

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jempa182
Copy link

@JennieDalgren JennieDalgren self-assigned this Aug 29, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project! Also, love the style and design of it.

Use of Semantic HTML:

Great job using semantic tags like <header>, <main>, and <footer>. This improves both accessibility and SEO.

CSS Grid and Flexbox Usage:

Excellent application of both CSS Grid and Flexbox. The use of Grid for the main layout and Flexbox for smaller components is well-balanced.
Ensure that grid and flex properties are only applied where necessary to avoid unnecessary complexity.

Alt Text for Images

Ensure all images have descriptive alt text for accessibility.

Code structure

There are some instances of repeated CSS properties across different selectors. Refactor these into a single class to keep your CSS DRY (Don't Repeat Yourself).

Example on refactoring:
You have the following button styles repeated in both .btn-primary and .btn-secondary

.btn-primary, .btn-secondary {
  padding: 10px 20px;
  border-radius: 5px;
  font-size: 16px;
  text-align: center;
}

Instead of repeating these properties, you can create a base class (e.g., .btn) and apply it to both .btn-primary and .btn-secondary.

.btn {
  padding: 10px 20px;
  border-radius: 5px;
  font-size: 16px;
  text-align: center;
}

.btn-primary {
  background-color: blue;
  color: white;
}

.btn-secondary {
  background-color: gray;
  color: black;
}

This keeps your code DRY and more maintainable!

Keep up the good work! With a few tweaks, your project will be even stronger. 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants