Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 1: Article #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariagraziafiori
Copy link

@mariagraziafiori mariagraziafiori commented Oct 2, 2021

I created as a first test a Onepager about some interior designs.

  • Main Elements: Head (Nav), Body, Footer
  • Formats: Texts, Images and Embedded Video
  • Interactive Elements: External Links, Anchor Links
  • Not intended for deployment

About the Content: The real challenge for the first project was finding out what exactly to create. This choice is the foundation of all and determines what the layout will finally look like.

About the Code: I am all in all happy with the results. I struggled the most with the display of the images. It could be improved by creating a whole gallery for each design which is "swipeable" on a mobile device.

Copy link

@esteficodes esteficodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈Impressive site! 😀 I like how you combined colors and display. Testing around it I noticed that so far it works great. The next step would be to add media queries so that it can look beautiful in every device screen. Start designing from the mobile display first. Remember to remove the comments from your code so it's clean and nice.😊

@@ -4,18 +4,225 @@
<head>
<meta charset="utf-8" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI! I'm Estefanía and I'll be taking a look at your code so that we can leave it as functional and shiny as possible.👋😀

Comment on lines +44 to +56
<div>
<p>Though it has largely taken a backseat to more casual styles over the last several years, traditional design is undergoing a renaissance of sorts, and we find ourselves falling for the stately rooms and beautiful antiques all over again.</p>
<p>It's not difficult to deduce that traditional design is inspired by—you guessed it—tradition. Specifically, traditions of 18th and 19th-century European interiors, albeit in a more timeless approach. <b>Symmetry, harmony, and understated elegance</b> are defining traits.</p>
<p>Classical furniture, intricate details, and rich colors abound in traditional interiors, resulting in decidedly formal yet functional spaces. Architecture is another important component, with detailed millwork such as crown molding and wainscoting playing a significant role.</p>
<h3>Characteristics</h3>
<ul>
<li>Rich, warm and inviting feel</li>
<li>Elegant and comforting</li>
<li>It features the "familiar"</li>
<li>Use of natural woods</li>
<li>Creamy colors (e.g. beige, ivory, eggshell and white)</li>
</ul>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice indentation!

Comment on lines +85 to +90
<ul>
<li>Mostly bold colors</li>
<li>Wide variety of patterns</li>
<li>Eclectic and fun</li>
<li>Unconventional</li>
</ul>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, watch out for the ul tags indentation. They should be aligned.

<li>Use of bare bricks, metals, concrete and wood</li>
<li>Recycled materials</li>
<li>Everything should be functional</li>
</ul>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before with the list tags. Should be aligned.

Comment on lines +3 to +13
nav {
display: flex;
align-items: center;
justify-content: center;
position: sticky;
top: 0;
z-index: 100;
background: rgb(249, 249, 249);
padding-top: 10px;
padding-bottom: 10px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love what you did here with the nav menu!

Comment on lines +82 to +84
body a:hover {
color: brown;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants