Kimberly's project #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
reviewed
Nov 21, 2023
Comment on lines
+12
to
+15
| <link | ||
| href="https://fonts.googleapis.com/css2?family=MuseoModerno:wght@300&display=swap" | ||
| rel="stylesheet" | ||
| /> |
| <h1>Hello there! 👋🏼</h1> | ||
| <img | ||
| src="images/shibuya-top.png" | ||
| alt="Shibuya's scramble crossing by night" |
There was a problem hiding this comment.
Great that you added alt tags - it's super important!
| margin: 0px; | ||
| } | ||
|
|
||
| /* How can I delete the minimal border between webpage and big image on top?*/ |
| color: blue; | ||
| font-family: MuseoModerno; | ||
| font-size: 100px; | ||
| /* How can I make the image align with the size of the text?*/ |
There was a problem hiding this comment.
I'm not sure what you mean - I think this looks super cool!
| } | ||
|
|
||
| img { | ||
| /* I don't understand why I need to work with "block" here... */ |
There was a problem hiding this comment.
The img element's default is to display inline, and if you don't want to images next to each other, display: block; is a good choice
| margin-left: auto; | ||
| margin-right: auto; | ||
| width: 50%; | ||
| /* Can I somehow format the height of all images so that they are the same height and still look good?*/ |
There was a problem hiding this comment.
You can decide a fixed height, for sure! Just make sure to also add the object-fit: cover; to avoid distortion.
| 190, | ||
| 0.2 | ||
| ); /* Background for p with 30% opacity. RGBA is used to avoid the text to become opaque as well! */ | ||
| /* How can I add padding to p AND keep the background color? Like this it doesn ot work: padding: 20px 0px 20px 0px;*/ |
There was a problem hiding this comment.
It works for me, can you expand what you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.