Simone created a portfolio page #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
reviewed
Nov 7, 2022
| <title>Simone Steiger</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css" /> | ||
| <style> | ||
| @import url('https://fonts.googleapis.com/css2?family=Kalam:wght@300&display=swap'); |
Comment on lines
+22
to
+39
| <div class="talent" style="width: 200px; height: 250px;"> | ||
| <a href="./staging.html">Home Staging</a> | ||
| </div> | ||
| <div class="talent" style="width: 290px; height: 250px;"> | ||
| <a href="./model.html">Werbemodel</a> | ||
| </div> | ||
| <div class="talent" style="width: 240px; height: 250px;"> | ||
| <a href="./sprecher.html">Sprecherin</a> | ||
| </div> | ||
| <div class="talent" style="width: 200px; height: 250px;"> | ||
| <a href="./moderation.html">Moderatorin</a> | ||
| </div> | ||
| <div class="talent" style="width: 290px; height: 250px;"> | ||
| <a href="./sugaring.html">Sugaring</a> | ||
| </div> | ||
| <div class="talent" style="width: 240px; height: 250px"> | ||
| <a href="./theater.html">Schauspielerin</a> | ||
| </div> |
There was a problem hiding this comment.
Is there a reason these are not the same width? 🤔 Also, wouldn't it be nice if these were images 😍
Comment on lines
+13
to
19
| <header class="main"> | ||
| <h1>SIMONE STEIGER</h1> | ||
| <img src="./images/main.jpg"> | ||
| <span>Mit viel Freude spreche ich Dokumentationen, Hörbücher, Werbetexte und | ||
| vieles mehr für Sie ein. Gerne moderiere ich Ihren Event. Auch für | ||
| Fernsehproduktionen oder als Werbemodel bin ich buchbar.</span> | ||
| </header> |
There was a problem hiding this comment.
Nice header! It would be nice if you had the same header on all pages - so that the whole page is even more aligned (although I like that you're reusing the colors etc). Also, a navbar would be nice :)
There was a problem hiding this comment.
Comment on lines
+31
to
+38
| <img src="./images/stage3.jpg"> | ||
| <img src="./images/stage2.jpeg"> | ||
| <iframe width="480" height="270" src="https://www.youtube.com/embed/cIi89wHNmTE" | ||
| title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; | ||
| clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen> | ||
| </iframe> | ||
| <img src="./images/stage1.jpeg"> | ||
| <img src="./images/stage4.jpeg"> |
There was a problem hiding this comment.
Some of the images (and the video) are too wide for mobile, and it's causing a horizontal scroll effect that we'd like to avoid
Comment on lines
+96
to
+101
| .gallery { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| margin: 40px 0px; | ||
| } |
There was a problem hiding this comment.
These are also causing a horizontal scroll on some screen sizes. Try adding flex-wrap: wrap; to make them wrap when they don't fit :)
Comment on lines
+113
to
+118
| footer { | ||
| display: flex; | ||
| justify-content: space-around; | ||
| background-color: rgb(200, 240, 250); | ||
| padding: 20px; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.