Elina-mika-estefann-survey-projecy #89
Conversation
Co-authored-by: Elina Eriksson Hult <[email protected]> Co-authored-by: Estefanny <[email protected]>
…hanging colors once form is filled in. Added content in FavoriteInstrument component to apply the change of colors elements in css file
There was a problem hiding this comment.
Good job with this project. You are meeting all requirements.
It looks like you have worked well in branches based on your commits and git history.
Great job with splitting up the form into smaller chunks but still only submit the form once all questions are done.
Keep up the good work!
⭐
| fav_instrument={formData.fav_instrument} | ||
| fav_genre={formData.fav_genre} |
There was a problem hiding this comment.
stick to camelCase for props. As you've done in other components
| handleChange={handleChange} | ||
| /> | ||
| <FavoriteArtist value={formData.artist} onChange={handleChange} /> | ||
| <Submit handleSubmit={handleSubmit} /> |
There was a problem hiding this comment.
It doesnt seem like you have a handleSubmit prop on your Submit component. And no need either. The form submit is being handled by the onSubmit on line 8. This is triggered both by the 'enter' key and the press of a button with the type submit. You dont have to specify that event again on the submit button
Netlify link
https://musicpreferences.netlify.app/
Collaborators
[FannyEste] [ElinaEH]