Project React ToDo app by EmmaE #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinSkill
approved these changes
Apr 25, 2023
| import TaskList from 'components/TaskList'; | ||
| import tasks from 'reducers/task'; | ||
| import Header from 'components/Header'; | ||
| import TotalCompleteItems from 'components/TasksCompleted'; | ||
|
|
||
| export const App = () => { |
| </button> | ||
| <label htmlFor={`task_with_id${singleTask.id}`}> | ||
| Task completed | ||
| <input id={`task_with_id${singleTask.id}`} type="checkbox" value={singleTask.isDone} onChange={() => |
There was a problem hiding this comment.
I noticed that after refreshing the page. The completed count and checkboxes are not behaving correct. I think it can be a good idea to change value={singleTask.isDone} to checked={singleTask.isDone}
| }, | ||
| addTask: (store, action) => { | ||
| store.items = [action.payload, ...store.items]; | ||
| localStorage.setItem('taskList', JSON.stringify(store.items)); |
There was a problem hiding this comment.
Nice feature with the local storage!
| @@ -0,0 +1,45 @@ | |||
| /*eslint-disable*/ | |||
There was a problem hiding this comment.
Great structure of the code, easy to follow and understand
Comment on lines
+18
to
+20
| /*tasks = useSelector(state => state.tasks) | ||
| const completedTasks = tasks.filter(singleTask => singleTask.isDone) | ||
| completedTasks.length*/ |
There was a problem hiding this comment.
Maybe clean up this now when you moved it into it's own component.
| @@ -0,0 +1,15 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Good idea to have also this as its own component. Makes it easy to find exactly what you are looking for quick if you need to do updates/changes.
|
|
||
| ## View it live | ||
|
|
||
| Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about. | ||
| Ehttps://todo-app-emmaeng.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.