Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: new params for graphviz + solves #70 #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maciejczyzewski
Copy link

Changes:

Example (--graphviz-layout fdp):
Screen Shot 2021-06-09 at 15 27 40

- solve abs path bug Technologicat#70
- new params for graphviz (ranksep; layout)
- tested layout `dot`; `fdp` (square graph)
- updated `.gitignore` (files gen. after `visualize_pyan_architecture.sh`)
Copy link
Owner

@Technologicat Technologicat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jdb78 : anything to add?

@jdb78
Copy link
Collaborator

jdb78 commented Jun 10, 2021

@maciejczyzewski Could you give your consent to relicense your contributions under the MIT and BSD licences here: #68?

And: I think the readme changes for you to pyan3. I think we install pyan. Otherwise all good with me :)

@maciejczyzewski
Copy link
Author

maciejczyzewski commented Jun 10, 2021

Yeah, sure 😄 (already commented in #68)

I switched to pyan3 in readme since pip install pyan3 did not install the pyancommand on my machine as it should have.

Edit:
Should there be an additional line "pyan = pyan.main:main" here in https://github.com/Technologicat/pyan/blob/master/setup.py#L130

@lofidevops
Copy link

@Technologicat @jdb78 FWIW I have used this branch successfully on a moderately complex project, and it works as expected.

joenio added a commit to analizo/pyan that referenced this pull request Nov 9, 2024
The code included in this commit was adapted from the implementation on the
Pull-Request Technologicat#74 made by the author @maciejczyzewski

Resolves: Technologicat#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants