Skip to content

Commit

Permalink
fix(prettier): rollback to working version
Browse files Browse the repository at this point in the history
As you can see reported in prettier/prettier#15696, prettier 3.x won't work with plugins under the context of pre-commit. In practice, this means for us that XML won't get auto-formatted.

Pinning latest working combination.

@moduon MT-5455
  • Loading branch information
yajo committed Apr 2, 2024
1 parent b88a1b3 commit 3aa60bf
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .pre-commit-config.yaml.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,16 @@ repos:
args: [--fix, --exit-non-zero-on-fix]
- id: ruff-format
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.0.2
# HACK https://github.com/prettier/prettier/issues/15696
rev: v2.7.1
hooks:
- id: prettier
name: prettier + plugin-xml
args: [--plugin=@prettier/plugin-xml]
additional_dependencies:
# HACK https://github.com/prettier/pre-commit/issues/16#issuecomment-713474520
- prettier@3.0.2
- "@prettier/plugin-xml@v3.2.0"
- prettier@2.7.1
- "@prettier/plugin-xml@v2.2.0"
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
hooks:
Expand Down

0 comments on commit 3aa60bf

Please sign in to comment.