[FIX] Update longpolling route for Odoo 16.0

[PabloEForgeFlow]

As mentioned in Tecnativa/doodba#530, the old /longpolling/ route was replaced by /websocket in Odoo 16.0 (see odoo/odoo#75510). Currently, this results in the following error when a client tries to access the latter route (with the exception of threaded-mode odoo):

Traceback (most recent call last):
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 2002, in __call__
    response = request._serve_db()
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1588, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1615, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 1729, in dispatch
    return self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/custom/src/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/auto/addons/bus/controllers/websocket.py", line 23, in websocket
    return WebsocketConnectionHandler.open_connection(request)
  File "/opt/odoo/auto/addons/bus/websocket.py", line 818, in open_connection
    Websocket(request.httprequest.environ['socket'], request.session),
KeyError: 'socket'

This is caused by an undefined socket, which is only defined in environ when the request goes to the GeventServer's ProxyHandler or to the ThreadedServer, which uses a modified RequestHandler.

For Doodba projects using Traefik, the solution is pretty straightforward: update the longpolling route so that WebSocket traffic passes through the GeventServer. Apparently, Traefik handles WebSocket requests the same as it would HTTP ones, as stated here, so no further changes should be required. I've personally tested the changes presented in this PR and had no issues.

As for local environments running in pre-fork mode, I've applied the changes proposed by @yelizariev in Tecnativa/doodba#530, but making it work properly would still require the configuration of an external proxy such as Nginx.

[yajo]

According to my tests, the rule for <16 should be PathPrefix(`/longpolling/`) as it was, but the rule for >= 16 should be Path(`/websocket`).

[PabloEForgeFlow]

Line 157 should take care of that, but apparently I mistyped /longpolling/ as /longpoling/, should be fixed now.

[yajo]

I mean that you don't want PathPrefix(`/websocket`), but Path(`/websocket`) instead.

[PabloEForgeFlow]

I misread your first comment, sorry about that. Path does indeed seem the correct rule, changed it.

[yajo]

I don't think this is needed. Development is done in threaded mode, so only 1 port is needed.

[PabloEForgeFlow]

I agree that most users won't ever need it, but if for some reason someone tries to run devel.yaml with --workers > 1 (maybe they need to debug something in pre-fork mode), then it won't work.

Still, if you are sure, I will revert it.

[yajo]

If that's the case, then don't restrict this to only v16+. Older versions also used that port, right?

[PabloEForgeFlow]

You're right, fixed it.

[pedrobaeza]

Can you please rebase to get a green CI?

[PabloEForgeFlow]

Was wondering why it was failing, didn't notice the new commits. Rebased now, thanks.