Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate private addon readmes with markdown fragments #408

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Oct 10, 2023

Adds support for the latest changes found in maintainer tools.

Now, readmes will have a source digest, resulting in fewer rebuilds, and markdown portions are supported.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍 (although tests are 👎 )

@yajo
Copy link
Contributor Author

yajo commented Oct 16, 2023

The failure is in the main branch. #403 was merged with the same failure included.

@yajo yajo force-pushed the readme-md-generator-support branch from 6c5462b to ca1bb74 Compare October 24, 2023 11:36
@yajo
Copy link
Contributor Author

yajo commented Oct 24, 2023

I rebased, now that the main branch is green.

@pedrobaeza
Copy link
Member

Can you please check the CI error?

Adds support for the latest changes found in maintainer tools.

Now, readmes will have a source digest, resulting in fewer rebuilds, and markdown portions are supported.

Because of that, the readme generation is moved to be the last hook. This way, the digest will include all changes from above hooks.
@yajo yajo force-pushed the readme-md-generator-support branch from ca1bb74 to 03aa4be Compare October 26, 2023 07:56
@yajo
Copy link
Contributor Author

yajo commented Oct 26, 2023

I think it should be fixed now.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know syntax exactly, but I trust you :)

@pedrobaeza pedrobaeza merged commit 515dc8c into Tecnativa:main Oct 26, 2023
41 checks passed
@yajo yajo deleted the readme-md-generator-support branch October 27, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants