Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] The SMTP domain should prefix smtp #413

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

pedrobaeza
Copy link
Member

If not, mails are not delivered.

@Tecnativa

If not, mails are not delivered.
@pedrobaeza
Copy link
Member Author

@Tardo I asked you about this in #401 (comment), and you told me that it doesn't affect, but it does, as mails are not delivered without this, so I'm restoring it.

@Tardo
Copy link
Contributor

Tardo commented Oct 31, 2023

@pedrobaeza I currently have an instance configured with the template and it is capable of sending and receiving emails :/

@pedrobaeza
Copy link
Member Author

Well, I'm not experiencing the same, so better to let it as it was, unless you have any side-effect that let you to change this.

@Tardo
Copy link
Contributor

Tardo commented Oct 31, 2023

No problem. The only thing is the issue of having the 'smtp' part hardcoded... but I don't see a major problem either.

Maybe are matching 'smtp_canonical_default' with the hostname of the odoo service?

@pedrobaeza
Copy link
Member Author

Yes, I think it has to be with the docker internal naming scheme, not being able to route from odoo container to smtp container. As I'm not sure how to fix it, let's go to the hardcoded thing.

@Tardo
Copy link
Contributor

Tardo commented Oct 31, 2023

Ok, my apologies for my mistake

@pedrobaeza
Copy link
Member Author

No worries. It has been detected soon enough.

@pedrobaeza pedrobaeza merged commit b1b0d27 into main Oct 31, 2023
41 checks passed
@pedrobaeza pedrobaeza deleted the fix-smtp-domain branch October 31, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants