-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backup): convert odoo regex extensions #424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puedes hacer rebase para ver si te sale ya CI en verde? |
Still with error. Maybe it's provoked by this PR. |
Other builds pass green, and the one that fails says:
So it seems like you'll have to add credentials to authenticate with docker hub and thus increase the free pull limits. Or just retry until it passes. |
zamberjo
approved these changes
Jul 17, 2024
Please, rebase and let's see if the CI error gets fixed. |
The backup image [accepts a regexp on `DBS_TO_INCLUDE`][1]. But [Odoo uses a regexp with custom extensions][2] (`%h` and `%d`). If you use any of those extensions, the backup jobrunner will fail with `CalledProcessError`. Additionally, regexps usually contain a `$` symbol, which [needs to be escaped for docker-compose][3]. [1]: https://github.com/Tecnativa/docker-duplicity#dbs_to_includeexclude [2]: https://www.odoo.com/documentation/16.0/developer/reference/cli.html#cmdoption-odoo-bin-db-filter [3]: https://docs.docker.com/compose/compose-file/compose-file-v2/#variable-substitution BREAKING CHANGE: if your dbfilter contained `$$` previously, to do that escaping yourself, you will have to convert it to a single `$` @moduon MT-4191
I think this is ready to merge @pedrobaeza |
pedrobaeza
approved these changes
Oct 9, 2024
josep-tecnativa
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backup image accepts a regexp on
DBS_TO_INCLUDE
. But Odoo uses a regexp with custom extensions (%h
and%d
).If you use any of those extensions, the backup jobrunner will fail with
CalledProcessError
.Additionally, regexps usually contain a
$
symbol, which needs to be escaped for docker-compose.BREAKING CHANGE: if your dbfilter contained
$$
previously, to do that escaping yourself, you will have to convert it to a single$
@moduon MT-4191