-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Correct always using docker compose, even if it not compatible. #464
Conversation
4008588
to
713bb90
Compare
126425e
to
521d64d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message isn't very helpful. What about:
[FIX] docker compose command fallback
521d64d
to
0ca01b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Although now tests are red 🤔
0308753
to
3d61465
Compare
Seems like the odd CI error is due to the line being too long, but no error is triggered in the local |
In this change e2bc946 is always used docker compose. In docker versions 24.0.6 or lower, this is incompatible, and needs to use docker-compose