Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correct always using docker compose, even if it not compatible. #464

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

josep-tecnativa
Copy link
Contributor

In this change e2bc946 is always used docker compose. In docker versions 24.0.6 or lower, this is incompatible, and needs to use docker-compose

tasks_downstream.py Outdated Show resolved Hide resolved
tasks_downstream.py Outdated Show resolved Hide resolved
tasks_downstream.py Outdated Show resolved Hide resolved
tasks_downstream.py Outdated Show resolved Hide resolved
tasks_downstream.py Outdated Show resolved Hide resolved
tasks_downstream.py Outdated Show resolved Hide resolved
@josep-tecnativa josep-tecnativa force-pushed the fix-check-docker-compose-avaliable branch 3 times, most recently from 126425e to 521d64d Compare April 10, 2024 11:49
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message isn't very helpful. What about:

[FIX] docker compose command fallback

tasks_downstream.py Outdated Show resolved Hide resolved
@josep-tecnativa josep-tecnativa force-pushed the fix-check-docker-compose-avaliable branch from 521d64d to 0ca01b2 Compare April 11, 2024 11:41
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Although now tests are red 🤔

@josep-tecnativa josep-tecnativa force-pushed the fix-check-docker-compose-avaliable branch from 0308753 to 3d61465 Compare April 12, 2024 05:39
@josep-tecnativa
Copy link
Contributor Author

Seems like the odd CI error is due to the line being too long, but no error is triggered in the local pre-commit run -a.

@josep-tecnativa josep-tecnativa merged commit 50a4111 into main Apr 12, 2024
27 checks passed
@josep-tecnativa josep-tecnativa deleted the fix-check-docker-compose-avaliable branch April 12, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants