Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Delete obsolete labels #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX] Delete obsolete labels #485

wants to merge 1 commit into from

Conversation

josep-tecnativa
Copy link
Contributor

@josep-tecnativa josep-tecnativa commented Jul 25, 2024 •
edited
Loading

CC @Tecnativa TT50321

Fixing this #484

@josep-tecnativa josep-tecnativa force-pushed the fix-del-traefik1-rules-on-traefik2 branch from 3a2ade2 to 27e1b49 Compare July 25, 2024 13:01
@josep-tecnativa josep-tecnativa force-pushed the fix-del-traefik1-rules-on-traefik2 branch from 27e1b49 to 333ef9b Compare July 25, 2024 13:03
@josep-tecnativa
Copy link
Contributor Author

@yajo please, check this out

yajo
yajo suggested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're dropping support for traefik v1, you should remove that option from the questionnaire.

As a side note, you might consider adding CTT to your pipeline, so you can have a snapshots-based rendering of the project that helps you spot these failures early. I do it here and it helps a lot.

_traefik2_hosts_labels.yml.jinja
)
}}
{%- endif %}

{#- Normal routers #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These routers are wrong too.

@pedrobaeza
Copy link
Member

We mustn't remove Traefik 1 option. Just don't populate its labels if Traefik 2 is selected. And isn't this file exclusive for Traefik 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josep-tecnativa @pedrobaeza @yajo