Remove misticaCommon fix to an old Bundle.module bug #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojrp
requested review from
DavidMarinCalleja,
pbartolome,
dhidalgofadrique,
amegias,
cbarcom,
alejandroruizponce and
alexanegon
DavidMarinCalleja
approved these changes
Jan 13, 2025
amegias
approved these changes
Jan 13, 2025
salavert
approved these changes
Jan 14, 2025
alexanegon
approved these changes
Jan 14, 2025
cbarcom
approved these changes
Jan 14, 2025
pbartolome
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
In Wallet, all the previews crash due to an old fix implemented that seems to fail with the latest Xcode.
This PR removes that fix as it is the cause of the crashes and I don't see any other errors reverting it.
🚧 How do we do it?
Remove the fix and go back to using Bundle.module
The PR is done on the Swift 6 branch as Wallet is already using Swift 6, I have not tested it in main