WIP: fix: update balancer-sdk to fix fetchPools() error #1054
Conversation
|
Deploy preview for core ready! ✅ Preview Built with commit dae681a. |
|
Aah not so easy. When balancer-sdk calls llamarpc, it gives CORS error but that is a red herring, in reality the actual reason/response is 
E: I tested it with a free-tier api llamarpc apikey and i am getting the same error |
pocin
changed the title
apps/dapp/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "codegen:safe-api-v1": "yarn safe-api-v1-host && openapi --input ./src/safe/open-api/apiV1.json --output ./src/safe/open-api/client" | |||
| }, | |||
| "dependencies": { | |||
| "@balancer-labs/sdk": "^1.0.4", | |||
| "@balancer-labs/sdk": "1.1.6-beta.23", | |||
There was a problem hiding this comment.
Not sure about using a beta? Perhaps the largest main release?
There was a problem hiding this comment.
Did some more testing:
- ankr rpc seems to be handling the balancer-sdk requests just fine
- 1.1.5 does not work (still references old subgraph)
- i tried 1.1.5 with subgraph urls that i found floating around in discord, but it gives various different errors
- only the beta release works. It also seems to be calling the new balancer api
used in the new sdk https://github.com/balancer/b-sdk?tab=readme-ov-file#swap
no reply from balancer yet when the release goes out of beta, will keep trying
There was a problem hiding this comment.
proper release should be done soon
There was a problem hiding this comment.
No prod release yet, not sure what is the best course of action.
There was a problem hiding this comment.
Do you know why our dapp is broken but no one else's is?
I mean if we're broken at the moment we can just push the beta out?
There was a problem hiding this comment.
Do you know why our dapp is broken
from my research so far it's because the hosted subgraph endpoints got deprecrated (by thegraph.com)
but no one else's is
maybe they silently went with the beta release, or not all parts of the sdk depend on the subgraphs (my understadning of balancer does not go very deep), can't tell.
we can just push the beta out?
you mean use the beta release in our app deploy? The beta seems to be working as far as the dapp functionality goes.
|
There is no main release yet, the updated subgraphs are in the beta one as far as i could find. On Monday i can try injecting them into the older version, or be loud enough in balancer discord to get a release.
|
Oh so the latest v1.1.5 is broken? |
balancer-sdk requests are too large for llamarpc
|
Closed in favor of #1076 |
Description
FE swap feature fails with
fetchPools()error.Is likely caused by old subgraph being deprecated, fix is deployed in this beta release balancer/balancer-sdk#581 (comment). The linked issue also mentions new SDK being developed with a dedicated API. We might need to follow this and update when ready.
To verify this fixes it try previewing a swap with a wallet containing some TEMPLE
Fixes # (issue)
Checklist