Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): fix tabs action style and add test unit #2808

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(Tabs): fix tabs action style and add test unit #2808

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff5b197
fix(tabs): fix tabs action style and add test unit
Mar 20, 2024
d751307
test: update test snap and action render usage parseTNode
Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/_common
Open in desktop
Submodule _common updated 10 files
+4 −0 js/global-config/locale/ar_KW.ts
+14 −10 js/global-config/locale/en_US.ts
+4 −0 js/global-config/locale/it_IT.ts
+4 −0 js/global-config/locale/ja_JP.ts
+4 −0 js/global-config/locale/ko_KR.ts
+4 −0 js/global-config/locale/ru_RU.ts
+4 −0 js/global-config/locale/zh_CN.ts
+4 −0 js/global-config/locale/zh_TW.ts
+7 −0 style/web/components/tabs/_index.less
+5 −1 style/web/components/typography/_index.less
13 changes: 12 additions & 1 deletion src/tabs/TabNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const TabNav: React.FC<TabNavProps> = (props) => {
onChange = noop,
activeValue,
children,
action,
getDragProps,
} = props;

Expand Down Expand Up @@ -272,7 +273,17 @@ const TabNav: React.FC<TabNavProps> = (props) => {
<AddIcon />
</div>
) : null}
{props.action}
{action ? (
<div
className={classNames(
tdTabsClassGenerator('btn'),
tdTabsClassGenerator('nav-action'),
tdSizeClassGenerator(size),
)}
>
{action}
</div>
) : null}
</div>
<div
className={classNames(
Expand Down
22 changes: 22 additions & 0 deletions src/tabs/__tests__/tabs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,4 +340,26 @@ describe('Tabs 组件测试', () => {
expect(onDragSort.mock.calls[0][0].target.value).toEqual('vue');
expect(container.querySelectorAll('.t-tabs__nav-item-text-wrapper').item(0).firstChild.nodeValue).toEqual('react');
});

test('Tabs action', () => {
const { container } = render(
<Tabs
action="Action"
size={'medium'}
list={[
{
label: 'a',
value: 'a',
},
{
label: 'b',
value: 'b',
},
]}
/>,
);

expect(container.querySelector('.t-tabs__nav-action')).not.toBeNull();
expect(container.querySelector('.t-tabs__nav-action')).toBeInTheDocument();
});
});
Loading