fix: 修复 etcd keepAlive 无法及时关闭 context --story=121171780 #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zouxingyuks
force-pushed
the
fix/etcd
branch
from
734268d to
b2e299e
Compare
zouxingyuks
changed the title
yangfan-njupt
requested changes
Dec 11, 2024
zouxingyuks
force-pushed
the
fix/etcd
branch
2 times, most recently
from
68b0c8e to
d650d7e
Compare
yangfan-njupt
previously approved these changes
Dec 11, 2024
zouxingyuks
force-pushed
the
fix/etcd
branch
from
d650d7e to
30b5138
Compare
zouxingyuks
force-pushed
the
fix/etcd
branch
from
30b5138 to
e71c54d
Compare
yangfan-njupt
approved these changes
Jan 7, 2025
chenjr15
changed the title
chenjr15
reviewed
Jan 14, 2025
Comment on lines
+198
to
+202
| leaseResp, err := lease.Grant(s.ctx, defaultGrantLeaseTTL) | ||
| if err != nil { | ||
| logs.Errorf("grant lease failed, key: %s, err: %v", key, err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
另外在调用keepalive之前会第一次grant lease 也没有配置超时
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.