-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 安全组-资源 关联关系迁移到common表 --story=121678936 #1246
Open
KooKouse
wants to merge
2
commits into
TencentBlueKing:feat-sg-mgmt
Choose a base branch
from
KooKouse:github/feat-121678936
base: feat-sg-mgmt
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: 安全组-资源 关联关系迁移到common表 --story=121678936 #1246
KooKouse
wants to merge
2
commits into
TencentBlueKing:feat-sg-mgmt
from
KooKouse:github/feat-121678936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KooKouse
force-pushed
the
github/feat-121678936
branch
from
January 16, 2025 09:01
55f5a29
to
75c957a
Compare
KooKouse
force-pushed
the
github/feat-121678936
branch
from
January 17, 2025 08:20
75c957a
to
f79a5d9
Compare
chenjr15
reviewed
Jan 21, 2025
fxdgg
reviewed
Jan 21, 2025
fxdgg
reviewed
Jan 21, 2025
fxdgg
reviewed
Jan 21, 2025
err = g.createSGCommonRels(kt, enumor.TCloud, cvmID, sgCloudIDs, sgCloudIDToIDMap) | ||
if err != nil { | ||
// 不抛出err, 尽最大努力交付 | ||
logs.Errorf("create sg common rels failed, err: %v, rid: %s", err, kt.Rid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1、记录下cvmID, sgCloudIDs, one.InstanceId等参数吧
2、这里创建rel失败后,会有什么影响吗?是否需要配置日志告警?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rel创建失败,本地暂时看不到关联关系,需要由同步进行数据兜底
yangfan-njupt
requested changes
Jan 21, 2025
chenjr15
reviewed
Jan 22, 2025
chenjr15
reviewed
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.