feature: 轻量化部署优化 #2643 #2663
Merged
feature: 轻量化部署优化 #2643 #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonwan
reviewed
Dec 11, 2023
| @@ -24,15 +24,18 @@ public IamAppTransferAspect(AppScopeMappingService appScopeMappingService) { | |||
| this.appScopeMappingService = appScopeMappingService; | |||
| } | |||
|
|
|||
| @Pointcut("execution (* com.tencent.bk.job.common.iam.service.impl.BusinessAuthServiceImpl.auth*(..))") | |||
| @Pointcut("within(com.tencent.bk.job..*) " + | |||
| "&& execution (* com.tencent.bk.job.common.iam.service.impl.BusinessAuthServiceImpl.auth*(..))") | |||
| public void processAuthBusinessAction() { | |||
There was a problem hiding this comment.
搜索范围可以进一步细化到com.tencent.bk.job.common.iam.service.impl.BusinessAuthServiceImpl
There was a problem hiding this comment.
搜索范围可以进一步细化到com.tencent.bk.job.common.iam.service.impl.BusinessAuthServiceImpl
fix
jsonwan
reviewed
Dec 11, 2023
| @@ -17,11 +17,13 @@ | |||
| @Aspect | |||
| public class IamExceptionHandleAspect { | |||
|
|
|||
| @Pointcut("execution (* com.tencent.bk.sdk.iam.service.impl.PolicyServiceImpl.*(..))") | |||
| @Pointcut("within(com.tencent.bk.job..*) " + | |||
| "&& execution (* com.tencent.bk.sdk.iam.service.impl.PolicyServiceImpl.*(..))") | |||
There was a problem hiding this comment.
搜索范围可以进一步细化到com.tencent.bk.sdk.iam.service.impl.PolicyServiceImpl
jsonwan
reviewed
Dec 11, 2023
| public void processPolicyServiceAction() { | ||
| } | ||
|
|
||
| @Pointcut("execution (* com.tencent.bk.sdk.iam.helper.AuthHelper.isAllowed(..))") | ||
| @Pointcut("within(com.tencent.bk.job..*) " + | ||
| "&& execution (* com.tencent.bk.sdk.iam.helper.AuthHelper.isAllowed(..))") |
There was a problem hiding this comment.
搜索范围可以进一步细化到com.tencent.bk.sdk.iam.helper.AuthHelper
jsonwan
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jOOQ,spring-boot and aop. jOOQ/jOOQ#5902
AOP 编写参考：
https://docs.spring.io/spring-framework/docs/5.3.9/reference/html/core.html#writing-good-pointcuts