Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): fix resource plugin import #672

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix(openapi): fix resource plugin import #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ef96c
fix(openapi): fix resource plugin import
Han-Ya-Jun May 31, 2024
74edef7
fix(openapi): fix resource plugin import
Han-Ya-Jun May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dashboard/apigateway/apigateway/biz/plugin/plugin_synchronizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def sync(
existing_binding = remaining_key_to_binding.pop(key)

plugin_config_obj = existing_binding.config
plugin_config_obj.config = plugin_config_data.yaml
plugin_config_obj.config = plugin_config_data.yaml.encode().decode("unicode_escape")
plugin_config_obj.updated_by = username
plugin_config_obj.updated_time = now
update_plugin_configs.append(plugin_config_obj)
Expand All @@ -84,7 +84,7 @@ def sync(
type_id=plugin_type.id,
),
type=plugin_type,
yaml=plugin_config_data.yaml,
yaml=plugin_config_data.yaml.encode().decode("unicode_escape"),
created_by=username,
),
)
Expand Down
2 changes: 1 addition & 1 deletion src/dashboard/apigateway/apigateway/biz/resource/importer/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def _validate_plugin_config(self):
try:
yaml_validator.validate(
plugin_type.code,
plugin_config_data.yaml,
plugin_config_data.yaml.encode().decode("unicode_escape"),
plugin_type.schema and plugin_type.schema.schema,
)
except Exception as err:
Expand Down
Loading