Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary region parameter from Oauth2TokenHolder update #1944

Merged
merged 3 commits into from
Mar 6, 2025
Merged

fix: remove unnecessary region parameter from Oauth2TokenHolder update #1944

merged 3 commits into from
Mar 6, 2025

Conversation

piglei
Copy link
Collaborator

@piglei piglei commented Feb 28, 2025

  • fix: remove unnecessary region parameter from Oauth2TokenHolder update
  • docs: improve the docs of PrivateTokenHolder

jiayuan929
jiayuan929 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@jiayuan929 jiayuan929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piglei piglei force-pushed the account-tenancy branch from 69b9e90 to d934c27 Compare March 6, 2025 03:32
@piglei piglei merged commit 37ee7f2 into TencentBlueKing:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgetx jamesgetx jamesgetx left review comments

@jiayuan929 jiayuan929 jiayuan929 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piglei @jamesgetx @jiayuan929