feat: 新增记录变更事件的文件以及日志 #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlkaidChan
reviewed
Oct 12, 2024
| filePath := filepath.Join(absPath, ci.ConfigItemSpec.Name) | ||
| _, err := os.Stat(filePath) | ||
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| // content is not exist | ||
| // 记录需要新增的文件 | ||
| changeLog.Add = append(changeLog.Add, filepath.Join(ci.ConfigItemSpec.Path, ci.ConfigItemSpec.Name)) |
There was a problem hiding this comment.
这里应该不能用 filepath.Join，直接用 path.Join，filepath.Join 的分隔符会根据操作系统来决定，但是 ci.ConfigItemSpec.Path 默认都是用 / 分隔的，如果在 windows 下会变成 / 和 \ 混合在一起了
| @@ -285,6 +310,8 @@ func checkFileExists(absPath string, ci *sfs.ConfigItemMetaV1) (bool, error) { | |||
| } | |||
|
|
|||
| if sha != ci.ContentSpec.Signature { | |||
| // 记录需要更新的文件 | |||
| changeLog.Modif = append(changeLog.Modif, filepath.Join(ci.ConfigItemSpec.Path, ci.ConfigItemSpec.Name)) | |||
| } | ||
|
|
||
| // 检查文件路径是否在给定路径数组中 | ||
| if _, exists := pathSet[file]; !exists { |
There was a problem hiding this comment.
这里也需要在 windows 下验证看看，使用 filepath 会不会有问题，最好是只在真实操作文件的时候使用 filepath.Join，其他时候逻辑判断都用 path.Join
| } | ||
|
|
||
| // GetLatestChangeLogFromFile get the last data from the file that records change log | ||
| func GetLatestChangeLogFromFile(tempDir string) (*ChangeLog, error) { |
There was a problem hiding this comment.
这个函数看起来没有被其他地方引用，没用的话就先去掉吧
| } | ||
|
|
||
| // recordChangeLog 记录变更日志 | ||
| func (r *Release) recordChangeLog() error { |
There was a problem hiding this comment.
这里 changelog 有一个问题：
用户希望能在后置脚本里读到 changelog，所以 changelog 的写入可能要放到后置脚本之前
要不拆成两个 PR 吧😂，先把发布失败不能回滚的问题解决
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.