Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support output groups #20

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

kaycebasques
Copy link
Contributor

@kaycebasques kaycebasques commented Jan 31, 2025

Fixes #19

@kaycebasques
Copy link
Contributor Author

kaycebasques commented Jan 31, 2025

@tpudlik FYI re: https://pwrev.dev/263952

@kaycebasques
Copy link
Contributor Author

Notes from @tpudlik:

  • First thought was to use output attributes because it would remove the need for intermediary targets and allow us to use something like :doxygen_build.html instead.
  • But it turns out that output attributes don't support directories so output groups are the only viable solution for now.
  • The output groups should be documented in the rule string. (And probably elsewhere in the rules_doxygen docs.)

@TendTo
Copy link
Owner

TendTo commented Feb 3, 2025

I have to admit I had not used OutputGroups before. It does seem like a welcome addition for whoever may need it, thanks.

@TendTo
Copy link
Owner

TendTo commented Feb 3, 2025

If you feel like there is nothing more to add I will merge the pr

@kaycebasques
Copy link
Contributor Author

Thank you! Nothing more to add on my end so you're welcome to merge whenever

@TendTo TendTo merged commit 39d5d59 into TendTo:main Feb 3, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support output groups
2 participants