Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tendrl in SELinux enabled #244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TimothyAsirJeyasing
Copy link

tendrl-bug-id: #241
Signed-off-by: Timothy Asir J [email protected]

tendrl-bug-id: Tendrl#241
Signed-off-by: Timothy Asir J <[email protected]>
@TimothyAsirJeyasing
Copy link
Author

@r0h4n , @nthomas-redhat , @shtripat , Please review

Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of spelling and grammatical errors. This is quite depressing for reviewers :)

@@ -0,0 +1,197 @@
= Enable SELinux for tendrl

SELinux should be enabled in tendrl for the system which controled by selinux.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the grammar of sentence

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what is guideline for gluster nodes? do we suggest selinux enforcing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we suggest selinux enforcing for gluster nodes also.
I hope gluster have its own selinux policy.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gluster has its own selinux policy


Tendrl could be installed in a system where SELinux could be already enforced.
Currenlty Tendrl requires selinux to be in disable state. If tendrl disables
the selinux which may brack the existing policy(security concerns) of the system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/brack/break/

which runs selinux enabled.

A SELinux-enabled system that runs in permissive mode is not protected by SELinux.
which will leads to privilege escalation issue. This allows the system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/will leads/will lead/


A SELinux-enabled system that runs in permissive mode is not protected by SELinux.
which will leads to privilege escalation issue. This allows the system
to be attacked if it does not managed by Selinux completely. A normal user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/does not managed/is not managed/


Currently tendrl services like gluster-integration, node-agent, api,
monitoring-integration services are running as unconfined services.
ex1: system_u:system_r:unconfined_service_t:s0 18240 ? 02:51:40 tendrl-node-age
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep examples in {e.g}

==== Tendrl API impact:

SELinux policy files will be added in to this tendrl-api module.
This set of policies will be used at tendrl server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/This/These/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say tendrl-server, how integration services like {ceph/gluster}-integration would be taken care?

Copy link
Author

@TimothyAsirJeyasing TimothyAsirJeyasing Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope ceph and gluster have its own selinux policy we can use for the nodes.
it would be a heavy work if we need to write policy for that also.
However, if required we can add policy for that service also.


==== Tendrl commons impact:

SELinux policy files will be added in to this tendrl-commons module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/added to this tendrl-commons/added to tendrl-commons/

==== Tendrl commons impact:

SELinux policy files will be added in to this tendrl-commons module.
This will be used for every nodes participating in the tendrl.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the storage nodes (gluster nodes) as well ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Initially we will be having a common policy for tendrl nodes and server.


=== Work Items:


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the spec issue link here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i will create new issues and add.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


== Documentation impact:

The apis mentioned above need to be documented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apis??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, typo error.

@TimothyAsirJeyasing
Copy link
Author

Looks like i have sent an old rough copy. I will better close this one and send a new patch for review or i will update the doc in this.

tendrl-bug-id: Tendrl#241

Signed-off-by: Timothy Asir J <[email protected]>
@TimothyAsirJeyasing
Copy link
Author

@shtripat Please review

tendrl-bug-id: Tendrl#241

Signed-off-by: Timothy Asir J <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants