-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collisions in dbt_scd_id while calculating snapshots bug #168
Conversation
@@ -1,6 +1,6 @@ | |||
|
|||
{% macro teradata__snapshot_hash_arguments(args) -%} | |||
HASHROW({%- for arg in args -%} | |||
GLOBAL_FUNCTIONS.hash_md5({%- for arg in args -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using the dbt.hash
macro since the md5 function is configured differently in every environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also require dbt.hash to be configurable. One proposal on how to do that can be found here: Teradata/dbt-teradata-utils#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regrettably, our md5
implementation differs from the standard. Therefore, in our project, we have developed our own teradata__hash
macro to align with the database configuration. Consequently, to accommodate this modification, we will also need to create a distinct implementation of teradata__snapshot_hash_arguments
to cater to the custom md5
setup.
@rafaelkrysciak and @septimit we are modifying this implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me
resolves #160