fix: Improve FindNearbyPlayersSystem performance #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19. Refactoring of the
FindNearbyPlayersSystem
Also adds
AttackInProximityComponent
that was in some of the hostile critter prefabs. And also adjustsCheckAttackStopAction
to considerAttackInProximityComponent
.I noted a good performance improvement on my system.
Here is the before debug output:
And the after:
How to Test
I did the above tests using the Core Gameplay module with WildAnimals enabled. To make testing easier I changed the reference to the deer prefab in
WildAnimalsSpawnSystem
(line 80) toWildAnimals:HostileDeer
so that it spawns lots of entities that will look for players.If you want to recreate on your system the seed for the above image is
0pSFAX7zlh7pIlNnLj0DxOfJnzoUsoYc