feat(JOML): migrate rest of CommonWorld #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added a commit
to Terasology/StaticCities
that referenced
this pull request
Feb 6, 2021
* CommonWorld PR: Terasology/CommonWorld#8 * remove unused imports * update copyright
jdrueckert
added a commit
to Terasology/PolyWorld
that referenced
this pull request
Feb 6, 2021
* depends on Terasology/CommonWorld#8 * remove unused imports * update copyright
skaldarnar
approved these changes
Feb 6, 2021
| @@ -28,35 +15,35 @@ | |||
| private static final Logger logger = LoggerFactory.getLogger(CachingHeightMap.class); | |||
|
|
|||
| private final short[] height; | |||
| private final Rect2i area; | |||
| private final Rectanglei area; | |||
There was a problem hiding this comment.
We could potentially use BlockArea here. But let's address this when doing an overhaul of the whole cities code.
skaldarnar
pushed a commit
to Terasology/StaticCities
that referenced
this pull request
Feb 6, 2021
* CommonWorld PR: Terasology/CommonWorld#8 * remove unused imports * update copyright
skaldarnar
pushed a commit
to Terasology/PolyWorld
that referenced
this pull request
Feb 6, 2021
* depends on Terasology/CommonWorld#8 * remove unused imports * update copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to MovingBlocks/Terasology#3832