feat: update the phantom while typing #62
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened it just to have some reference but, in general, this PR should be merged only when the problem with the cursor is fixed(see sublimehq/sublime_text#5536 and #54) |
|
I feel, at this moment, the UX in the video is worse than without this PR. |
|
Just in case, here is how it works in VSCode vscode.mov |
|
Yes, it is horrible. That's why we shouldn't merge this one. We could close it, as I opened it purely to have some reference |
Keep it open is fine to help us remember this 😄 |
jfcherng
force-pushed
the
master
branch
2 times, most recently
from
10ee440
to
6c84c74
Compare
jfcherng
force-pushed
the
master
branch
4 times, most recently
from
b326282
to
bd39fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
This PR tries to emulate VSCode when the phantom(ghost) text is updated while typing(without triggering an extra request).
Unfortunately, due to the phantom API limitations, it is currently not possible(see the attached video)
phantom.mov
The main problem is that the cursor always jumps when updating the phantom in real time.