Capture Registries even earlier #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiqueck
changed the title
gniftygnome
added a commit
that referenced
this pull request
Jun 18, 2023
- Resolved crash with bclib during startup (thanks quiqueck) - WARNING: Biolith still does not work reliably when bclib is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a crashes related to BCLib by initialising the `registryManager´ before BCLib tries to set migrate the Biome-Data.
The call to
setRegistryManagerinMixinMinecraftServermay be redundant with this change, but it should not have any negative effect as it will simply capture the same registries.This should solve quiqueck/BetterNether#138 and #4