Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use PivotQL parser package directly from Github #549

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mabhub
Copy link
Collaborator

@mabhub mabhub commented Aug 3, 2023

@mabhub mabhub requested a review from Bo-Duke August 3, 2023 15:46
@Bo-Duke
Copy link
Member

Bo-Duke commented Aug 3, 2023

Still necessary since it has been merged since? jrmi/pivotql@1b8a239

@mabhub
Copy link
Collaborator Author

mabhub commented Aug 4, 2023

As long as the npm package is not updated…

Bo-Duke
Bo-Duke previously approved these changes Aug 4, 2023
@mabhub
Copy link
Collaborator Author

mabhub commented Aug 4, 2023

Parser is also working when package is installed from source repository !
So I'll remove custom build and install package through git.

@mabhub mabhub force-pushed the Temporarily-use-local-build-of-pivotql-parser branch from e429d8f to 2e5e005 Compare August 4, 2023 08:15
@mabhub mabhub changed the title Temporarily use custom build of pivotql parser Temporarily use PivotQL parser package directly from Github Aug 4, 2023
@mabhub mabhub requested a review from Bo-Duke August 4, 2023 08:16
@mabhub mabhub merged commit 2e5e005 into master Aug 4, 2023
2 checks passed
@mabhub mabhub deleted the Temporarily-use-local-build-of-pivotql-parser branch August 4, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants