Add ability to declare "embed" content to be displayed as iframe #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo-Duke
reviewed
Nov 9, 2023
|
|
||
| import { Icon } from '@blueprintjs/core'; | ||
|
|
||
| const bpIcons = [ |
There was a problem hiding this comment.
Maybe we should have this in a seperate file? A list of all usable bp icons is not a bad idea and could be used elsewhere
CFarcy
reviewed
Nov 13, 2023
src/modules/RA/DataLayer/components/tabs/EmbedTab/EmbedConfigField.js
Outdated
Show resolved
Hide resolved
Bo-Duke
force-pushed
the
Add-ability-to-declare-embed-content
branch
from
7b3276b
to
77eaa91
Compare
CFarcy
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.