Add check_mode support to hashivault_pki_role_list #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dezeroku
commented
Jul 2, 2024
| except Exception: | ||
| return {'data': []} | ||
| except Exception as e: | ||
| return {'failed': True, 'data': [], 'msg': str(e)} |
There was a problem hiding this comment.
Not sure if it's cleaner to drop data completely for the failed case output or return an empty list?
There was a problem hiding this comment.
I'm not sure if any other getters support check mode to have a pattern
There was a problem hiding this comment.
FWIW returning an empty list seems to be consistent with other roles: https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_ssh_role_list.py#L80 https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_token_role_list.py#L77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change in place data can be read in check mode