Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event system in api #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

404Setup
Copy link

@404Setup 404Setup commented Oct 3, 2024

Haven't done some testing on events yet, I'll come back to that later.

I'm sorry some parts are very crude, please give me feedback so I can improve them.

Available for both Bukkit and Bungeecord.

@404Setup 404Setup marked this pull request as ready for review October 3, 2024 07:21
@Test-Account666
Copy link
Owner

Hmmm, is there a reason why the switch from maven to gradle is necessary?

@404Setup
Copy link
Author

404Setup commented Oct 3, 2024

Hmmm, is there a reason why the switch from maven to gradle is necessary?

OK, it's rollback

@404Setup
Copy link
Author

404Setup commented Oct 3, 2024

The real reason is that maven suddenly failed to build indexes correctly on idea, which confused me a bit, so I changed it to gradle.

Maybe it's a bug in idea.

@404Setup 404Setup changed the title Add event system in api and migrate from maven to gradle Add event system in api Oct 4, 2024
@404Setup

This comment was marked as outdated.

@404Setup
Copy link
Author

404Setup commented Oct 6, 2024

bukkit events not compiling and not working have been fixed, and there is now a spigot example.

This example has been updated to the latest commit.

image

Example plugin source | Example plugin jar file | PlugManX Event jar file

@Test-Account666
Copy link
Owner

So... I finally came around to looking at the code.

I'd like to have proper bulk-operation support with the events.

Not like the PreDisablePluginEvent having a bool. That doesn't feel right

@Test-Account666
Copy link
Owner

I also think the user should also be informed about what happened, if an event has been cancelled

@404Setup
Copy link
Author

404Setup commented Oct 8, 2024

Let me think about what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants