Issue 1931: Pagination not working properly for combined filters list. #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression from the aggressive performance optimizations such as commit b2c538c. The case that is not correctly handled is where there are multiple separate field values being selected and filtered upon. This reverts the problematic optimization to ensure that the generated queries are correct. This has a cost of losing a significant performance optimization. The performance optimization will have to be re-looked at and a more correct approach without any regressions will need to be figured out.
smutniak
previously approved these changes
May 8, 2024
…ers list." This reverts commit 5ce9f38. The plan is to go with a smarter design that conditionally uses the aggressive query optimization.
This is a regression from the aggressive performance optimizations such as commit b2c538c. The case that is not correctly handled is where there are multiple separate field values being selected and filtered upon. The solution here is different from the previous solution in commit 5ce9f38. This approach preserves the aggressive optimization but when there are more than one filter values being filter it then disables the filter. This allows for using the aggressive optimization whenever possible. This uses the basic non-optimized select query (with a count) when there are two or more field values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1931
This is a regression from the aggressive performance optimizations such as commit b2c538c.
The case that is not correctly handled is where there are multiple separate field values being selected and filtered upon.
Instead of fully removing the optimization, this uses the optimization when there are zero or one field_values being filtered on. Then when there are two or more field_values then omit the optimization.