feat: fetch available versions into dropdown when adding frozen version #96
+153
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a valid repository is entered, we fetch a list of available versions from the repository when "enter" is pressed and let the user select from that list. Added some UI anehancements (e.g. disabled submit button if no version is selected).
|
@TfTHacker I was wondering if you have noticed the PRs I submitted and if so, if there's anything I could do to facilitate your review? |
|
Johan, sorry for the delayed. I have been rather swamped these days. Can you contact me on Discord? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a user-experience enhancement.
Open question: we indicate a valid repository by drawing a green border around the address, and red for invalid repositories. We also enable/disable the version dropdown respectively. Not sure this is good practice, but certainly helps the user when navigating the UI.
Ideas for further enhancement: