Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT 379 add new organizational units to mir institutes #278

Merged
merged 3 commits into from
Nov 7, 2024
Merged

DBT 379 add new organizational units to mir institutes #278

merged 3 commits into from
Nov 7, 2024

Conversation

Antoniafriedrich
Copy link
Contributor

adlerre
adlerre requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@adlerre adlerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit only changes!

@Antoniafriedrich
Copy link
Contributor Author

My second commit is only the changes requested in the ticket. The first one is considering the changes on the institutes done in the dbt directly, so uploading the new file causes no incompatibilities or errors.

Would you like me to revert the first commit?

@adlerre
Copy link
Member

adlerre commented Nov 7, 2024

Would you like me to revert the first commit?

Yes and the last one. It's easier to track changes.

@Antoniafriedrich
Copy link
Contributor Author

For tracking changes it is possible to view the commits seperately. If reverting them is wanted, how should I make sure the changes are up to date with the dbt institutes? With a seperate pull request? What do you suggest?

@Antoniafriedrich Antoniafriedrich force-pushed the issues/DBT-379-add-new-organizational-units-to-mir-institutes branch from 3738f94 to 3eb8715 Compare November 7, 2024 10:23
@Antoniafriedrich Antoniafriedrich force-pushed the issues/DBT-379-add-new-organizational-units-to-mir-institutes branch from 3eb8715 to 0464dd8 Compare November 7, 2024 11:19
@adlerre adlerre self-requested a review November 7, 2024 11:57
@adlerre adlerre merged commit 1fb2ed9 into 2022.06.x Nov 7, 2024
5 checks passed
@adlerre adlerre deleted the issues/DBT-379-add-new-organizational-units-to-mir-institutes branch November 7, 2024 11:57
yagee-de added a commit that referenced this pull request Jan 7, 2025
@yagee-de
Merge branch '2022.06.x' into 2023.06.x
05d351f 
* 2022.06.x:
  overwrite mir.date.issued in properties
  Update mir_institutes.xml (#277)
  DBT 379 add new organizational units to mir institutes (#278)
  update mir_institutes as of 2024-10-29
Antoniafriedrich added a commit that referenced this pull request Jan 13, 2025
@Antoniafriedrich
DBT 379 add new organizational units to mir institutes (#278)
b370413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerre adlerre adlerre approved these changes

@eckstueck eckstueck Awaiting requested review from eckstueck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antoniafriedrich @adlerre