-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for flat reductions to damage multipliers #333
Open
kgscialdone
wants to merge
8
commits into
ThaumRystra:develop
Choose a base branch
from
kgscialdone:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okay, I think I've finally got all the major kinks worked out of this. Should be properly ready for review and potential merge. |
I will update this to the 2.1 action/computation engine changes and merge once that's done. |
ThaumRystra
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, see feature request.
Adds a Reduction type to Damage Multipliers, which reveals a new Reduction Amount field when selected. When damage is applied, relevant reduction amounts are subtracted from the damage after multipliers, and cannot reduce damage below 0.
Potential good features to add before merging:
Potential gotcha: the
value
of a multiplier in Reduction mode is-1
, which may cause issues with calculations that naively assume the value can be multiplied in directly. It may be best to adjust this before merging, but I'm not sure what the best alternative would be.