Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for flat reductions to damage multipliers #333

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

kgscialdone
Copy link
Contributor

As discussed on Discord, see feature request.

Adds a Reduction type to Damage Multipliers, which reveals a new Reduction Amount field when selected. When damage is applied, relevant reduction amounts are subtracted from the damage after multipliers, and cannot reduce damage below 0.

Potential good features to add before merging:

  • Before/after multipliers option (5e RAW is always after iirc but homebrew/DMs may differ)
  • Adjustable minimum value after reduction (somewhat tricky since different reductions may have different minimums)

Potential gotcha: the value of a multiplier in Reduction mode is -1, which may cause issues with calculations that naively assume the value can be multiplied in directly. It may be best to adjust this before merging, but I'm not sure what the best alternative would be.

@kgscialdone
Copy link
Contributor Author

Okay, I think I've finally got all the major kinks worked out of this. Should be properly ready for review and potential merge.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

@ThaumRystra
Copy link
Owner

I will update this to the 2.1 action/computation engine changes and merge once that's done.

Copy link
Owner

@ThaumRystra ThaumRystra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants