dddice integration POC 1 #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -197,7 +197,7 @@ | |||
| // If the source and the hidden Element are different | |||
| // hide the source and reveal the hidden element | |||
| let originalSourceTransition = source.style.transition; | |||
| if (hiddenElement !== source){ | |||
| if (hiddenElement && hiddenElement !== source){ | |||
There was a problem hiding this comment.
I added this because after a roll I got a hiddenElement undefined error which prevented the action buttons from resetting after the roll
CelesteBloodreign
force-pushed
the
dddice-integration
branch
from
53a930f
to
68c014e
Compare
| @@ -186,6 +187,7 @@ export default { | |||
| }, | |||
| }, | |||
| mounted() { | |||
| setUpDddiceSdk(); | |||
There was a problem hiding this comment.
This call sets up the dddice sdk, inserts the canvas, and creates a connection to the dddice servers.
There is probably a way better place to call this from, I'm just not sure where is the correct place. For the sake of the POC i thought this was good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.