Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo structure for restructuring data_structures #1283

Closed
wants to merge 6 commits into from
Closed

demo structure for restructuring data_structures #1283

wants to merge 6 commits into from

Conversation

yaoyhu
Copy link

@yaoyhu yaoyhu commented Jul 1, 2023

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Sorry for the late PR, please check my demo structure. If it is OK, I'll continue pushing my codes to re-construct all the data_structures codes in later months.

yaoyhu
yaoyhu commented Jul 1, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
yaoyhu
yaoyhu commented Jul 1, 2023
View reviewed changes
Copy link
Author

@yaoyhu yaoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo structure: Please let me know if anything need to be improved!

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 3, 2023
Panquesito7
Panquesito7 requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall! 🚀

data_structures/include/forehead/forehead.h Outdated Show resolved Hide resolved
data_structures/include/forehead/forehead.h Outdated Show resolved Hide resolved
data_structures/include/forehead/forehead.h Outdated Show resolved Hide resolved
data_structures/src/list/sqlist.c Outdated Show resolved Hide resolved
data_structures/test/sqlist_test.c Outdated Show resolved Hide resolved
@yaoyhu
Copy link
Author

yaoyhu commented Jul 4, 2023

I'll improve them. Thanks for your time!
I noticed that some bugs occur in Linux, but work in macOS, I'll fix that later.

yaoyhu
yaoyhu commented Jul 4, 2023
View reviewed changes
Copy link
Author

@yaoyhu yaoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo reformed! Please let me know if anything need to be improved!

Panquesito7
Panquesito7 requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

data_structures/src/list/sqlist.c Outdated Show resolved Hide resolved
data_structures/src/list/sqlist.c Show resolved Hide resolved
data_structures/test/sqlist_test.c Outdated Show resolved Hide resolved
data_structures/test/sqlist_test.c Show resolved Hide resolved
data_structures/CMakeLists.txt Show resolved Hide resolved
@yaoyhu
Copy link
Author

yaoyhu commented Jul 21, 2023

Thanks for your time! Again, please let me know if anything need to be improved! Your proposal will be used as my template in my later PRs once this one is accepted!

yaoyhu
yaoyhu commented Jul 28, 2023
View reviewed changes
Copy link
Author

@yaoyhu yaoyhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reformed.

Edit: I modified the ‘.clang-format’ file with a small change to make it conform to the CMU bracket coding style #1275.

@yaoyhu yaoyhu mentioned this pull request Aug 21, 2023
Closed
realstealthninja
realstealthninja approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaoyhu
yaoyhu commented Aug 22, 2023
View reviewed changes
Copy link
Author

@yaoyhu yaoyhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 22, 2023
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 requested changes

@realstealthninja realstealthninja realstealthninja approved these changes

@tjgurwara99 tjgurwara99 Awaiting requested review from tjgurwara99 tjgurwara99 is a code owner

@alexpantyukhin alexpantyukhin Awaiting requested review from alexpantyukhin alexpantyukhin is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaoyhu @Panquesito7 @realstealthninja