Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #59

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Update CONTRIBUTING.md #59

merged 1 commit into from
Sep 10, 2023

Conversation

ZoomRmc
Copy link
Contributor

@ZoomRmc ZoomRmc commented Sep 10, 2023

  • Nim v2 is out
  • Add result return style guide
  • Various small fixes

@ZoomRmc
Update CONTRIBUTING.md
c1a6fc7 
- Nim v2 is out
- Add result return style guide
dlesnoff
dlesnoff approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@dlesnoff dlesnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is a pleasure to read.

@dlesnoff dlesnoff merged commit 348e76a into TheAlgorithms:main Sep 10, 2023
@ZoomRmc
Copy link
Contributor Author

ZoomRmc commented Sep 10, 2023

@dlesnoff thanks a lot.
I've missed a typo on line 145 ("ino" -> "in"). You could fix it directly, since you have the merge rights, or I'll piggyback a fix next time I change anything else.

@dlesnoff
Copy link
Collaborator

I can not change my own contributions…
Have you checked the spelling fixes in the PR made by SatinWulker #38 ?
There's the capitalization of titles, lot of small changes already proposed that could be the object of a new PR. Either you fork his branch and you push changes from his PR (even easier with the gh CLI, since you can just gh checkout pr 38), or you create a new PR.
You can piggyback the fix there. As you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlesnoff dlesnoff dlesnoff approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZoomRmc @dlesnoff