-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upload_coverage_report.yml
#600
Add upload_coverage_report.yml
#600
Conversation
4deca91
to
6f398c0
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
543d109
to
6030759
Compare
f99ea4d
to
6030759
Compare
6030759
to
88b5ee9
Compare
The secret will not be passed to workflows triggered from forks (which 99% of PRs are from). |
I haven't thought about that.
On some days codecov really has some issues (just have a look at all of these failed runs). In any case: should I do something additional regarding this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try without authentication first. If we see any issues or v3 is deprecated, we'll explore using authentication. I'd like to add it even today, but see no way to make it work at the moment.
Pull Request Template
Description
This PR integrates this repository with Codecov (TheAlgorithms exist there already). You can see the result for this PR here.
The created
yml
file was checked withyamllint
with--strict
flag.Type of change
Please delete options that are not relevant.
Checklist:
I ran bellow commands using the latest version of rust nightly.I rancargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.I rancargo fmt
just before my last commit.I rancargo test
just before my last commit and all tests passed.I added my algorithm to the correspondingmod.rs
file within its own folder, and in any parent folder(s).I added my algorithm toDIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.