Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Average Marginal Ranking Loss Function #742

Merged
merged 22 commits into from
Jul 30, 2024

Conversation

jkauerl
Copy link
Contributor

@jkauerl jkauerl commented Jun 11, 2024

Pull Request Template

Description

PR including the implementation for the Marginal Ranking Loss Function of this issue #559 . It creates a new file called marginal_ranking.rs with the function called mrg_ranking_loss. This implementation is inspired on the documentation of PyTorch of Marginal Ranking.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

PD: Im new to Rust and Open Source so I would love a clarification regarding the items I did not checked. Also let me know if I should squash the commits. Last PR had a wrong branch name #733.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (1d9c510) to head (c7cb14b).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   94.95%   95.06%   +0.11%     
==========================================
  Files         303      309       +6     
  Lines       22533    22796     +263     
==========================================
+ Hits        21396    21672     +276     
+ Misses       1137     1124      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkauerl
Copy link
Contributor Author

jkauerl commented Jul 11, 2024

Made some pretty major updates following suggestions I have recieved before.

DIRECTORY.md Outdated Show resolved Hide resolved
@vil02 vil02 changed the title Implementation of Marginal Ranking Loss Function Implementation of Average Marginal Ranking Loss Function Jul 30, 2024
@vil02 vil02 merged commit 7833c0c into TheAlgorithms:master Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants