Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Longest Common Subsequence Implementation #771

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

sozelfist
Copy link
Contributor

Changes made

  • Decompose the longest_common_subsequence to use helper functions
  • Rewrite tests using macro
  • Naming variables and functions descriptively
  • Add docstrings

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

- Decopose the `longest_common_subsequence` to use helper functions
- Rewrite tests using macro
- Naming variables and functions descriptively
- Add docstrings
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (7833c0c) to head (7c9685b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   95.06%   95.07%           
=======================================
  Files         309      309           
  Lines       22796    22803    +7     
=======================================
+ Hits        21672    21679    +7     
  Misses       1124     1124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozelfist
Copy link
Contributor Author

Let's have a look, @vil02

@sozelfist sozelfist requested a review from vil02 July 26, 2024 07:29
@vil02 vil02 merged commit 3c50b91 into TheAlgorithms:master Jul 31, 2024
4 checks passed
@sozelfist sozelfist deleted the ref/dp/lcs branch August 1, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants