Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Coin Change Implementation #773

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

sozelfist
Copy link
Contributor

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

- Use Rust closures to streamline the implementation
- Rewrite tests using macro
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.06%. Comparing base (06cbf48) to head (ab7e0f4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #773   +/-   ##
=======================================
  Coverage   95.05%   95.06%           
=======================================
  Files         308      309    +1     
  Lines       22752    22792   +40     
=======================================
+ Hits        21628    21668   +40     
  Misses       1124     1124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 3 test cases:

@vil02 vil02 merged commit b8fa915 into TheAlgorithms:master Aug 1, 2024
4 checks passed
@sozelfist sozelfist deleted the ref/dp/coin_change branch August 1, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants