Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: include unneeded_field_pattern #796

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 30, 2024

Pull Request Template

Description

This PR removes the unneeded_field_pattern from the list of suppressed lints.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@vil02 vil02 requested a review from siriak September 30, 2024 22:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (a8ec294) to head (8ee0d06).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         310      310           
  Lines       22513    22513           
=======================================
  Hits        21462    21462           
  Misses       1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review September 30, 2024 22:20
@vil02 vil02 requested a review from imp2002 as a code owner September 30, 2024 22:20
@siriak siriak merged commit 296e610 into TheAlgorithms:master Oct 1, 2024
4 checks passed
@vil02 vil02 deleted the include_unneeded_field_pattern branch October 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants