Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Longest Continuous Increasing Subsequence Implementation #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sozelfist
Copy link
Contributor

Changes

  • remove tracking_vec to reduce mem usage and simplify logic
  • keep track of the start of the curr subseq and updated max_start and max_len when a longer subseq was found
  • rewrite tests with macro

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

- remove `tracking_vec` to reduce mem usage and simplify logic
- keep track of the `start` of the curr subseq and updated `max_start`
and `max_len` when a longer subseq was found
- rewrite tests with macro
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (74db252) to head (667d6c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   95.33%   95.32%   -0.01%     
==========================================
  Files         310      310              
  Lines       22521    22488      -33     
==========================================
- Hits        21470    21437      -33     
  Misses       1051     1051              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants