Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logistic regression & optimizing the gradient descent algorithm #832

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

prkbuilds
Copy link
Contributor

@prkbuilds prkbuilds commented Oct 24, 2024

Pull Request Template

Description

Logistic regression is a data analysis technique that uses mathematics to find the relationships between features and the label. It then uses this relationship to predict the value of one of those factors based on the other.

I've added this algorithm under #578 and I've made some optimization changes to the better suit the usage.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why PR checks are failing

@prkbuilds
Copy link
Contributor Author

Hey @siriak They are failing due to the failed test cases. I'm working on them and will push the correct ones soon

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (1ef9bcb) to head (da1b10d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   95.38%   95.40%   +0.01%     
==========================================
  Files         312      313       +1     
  Lines       22645    22699      +54     
==========================================
+ Hits        21601    21655      +54     
  Misses       1044     1044              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prkbuilds prkbuilds requested a review from siriak October 26, 2024 03:31
@siriak siriak merged commit 858443e into TheAlgorithms:master Oct 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants